Skip to content

Removes the grace period for the rubocop Gitlab/TokenWithoutPrefix

Nick Malcolm requested to merge 439542-remove-grace-period-for-rubocop-tokenwithoutprefix into master

What does this MR do and why?

Removes the grace period for the rubocop Gitlab/TokenWithoutPrefix that was added in Enforce prefixing for new tokens with a rubocop (!142632 - merged).

The rubocop was added with a graceperiod. As it has been more than one week with no warnings, it can be safely lifted. (We had to wait til on or after 2024-02-02 11:20 UTC)

See https://docs.gitlab.com/ee/development/rubocop_development_guide.html#cop-grace-period

Closes #439542 (closed)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Easiest way is to watch the rubocop job in this MR's pipeline. But also:

% rubocop app lib ee/app ee/lib --only Gitlab/TokenWithoutPrefix
Inspecting 14130 files
.............................
14130 files inspected, no offenses detected

or

% bundle exec rubocop --parallel

# Takes a long time.
Edited by Nick Malcolm

Merge request reports