Skip to content

Include approval_rule_id in uniqueness scope

Hunter Stewart requested to merge hustewart-validate-group-approval into master

Issue: update Deployments::Approval validations (#442538 - closed)

Related bug: Multiple approvers for protected environments g... (#425759 - closed)

Why

Users should be able to approve a deployment once for each rule they can satisfy.

This covers the use case of approving for multiple groups since the group_id is on the approval_rule.

An initial MR has been merged to drop existing unique index, and replace it with an index that includes approval_rule_id

There will be a future MR to update the Deployments::Approval service that will allow this to work via GraphQL.

What

  • Include approval_rule_id in uniqueness scope.
  • Update spec for new model validation.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Hunter Stewart

Merge request reports