Close monitor alert widget popover after change
3/3 Broke the "use badges to display alerts on mertric graphs" issue (https://gitlab.com/gitlab-org/gitlab-ee/issues/11782) into 3 parts.
- Actual issue - this MR
- CE backport https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/30483**
- Hiding the alert widget popover as soon as action is taken - This is a related issue but not directly to this MR hence in a separate MR here https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/14540
Alert popover in the monitoring dashboard doesn't close as soon as Save/Update/Delete is clicked and waits for the XHR to complete. Because the loading spinner is moved under to alert icon (https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/14542), this Alert popover would hide the spinner when open. Ideally, this would have been O.K. but following this conversation https://gitlab.com/gitlab-org/gitlab-ee/issues/11782#note_188153621 the best way to go forward is to immediately hide the popover as soon as action is taken.
| Before | After |
|---|---|
 |
 |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team