Skip to content

Increase spec coverage for desired sharding keys

Manoj M J requested to merge mmj-changes-to-desired-sharding-key-spec into master

What does this MR do and why?

For #442553 (closed)

This MR increases spec coverage for desired sharding keys such that a desired sharding key:

  • should always be connected to parent via a Foreign key, unless exempted.
  • the column must be always non-nullable, unless exempted.

This MR also moves helper methods to a new module so that it can be reused across specs.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Manoj M J

Merge request reports