Add empty state to pending members page

changed milestone to %16.10

added frontend grouputilization sectionfulfillment labels

1 Message

CHANGELOG missing:

If this merge request needs a changelog entry, add the Changelog trailer to the commit message you want to add to the changelog.

If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

Reviewer roulette

Category	Reviewer	Maintainer
frontend	`@mcavoj` (UTC+1, 2 hours behind author)	`@himkp` (UTC+1, 2 hours behind author)

Please check reviewer's status!

Reviewer is available!
Reviewer is unavailable!

Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

Hey @alex_martin, I got two options for the image size that I need to get PM input which one to pick

default height	220px height	todos page for reference

In the todos page when there is not todos left, we should the same image and heading but we also add 2 lines. The idea behind increasing the height is to compensate for extra the whitespace in the page.

Also, do we need to make any adjustments for the copy or it's good as it's now for a first iteration?

Bundle size analysis [beta]

This compares changes in bundle size for entry points between the commits 03889419 and a8aaafda

Special assets

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
average	4.21 MB	4.21 MB	-	0.0 %
mainChunk	3.21 MB	3.21 MB	-	0.0 %

Please look at the full report for more details

Quarantined Fulfillment QA E2E Tests

The following Fulfillment QA E2E tests are in quarantine. If your changes would be covered by these tests, please be sure to perform manual testing.

Description	Location
Fulfillment Utilization when admin sets user cap limit for group shows members over limit as pending for approvals	./qa/specs/features/ee/browser_ui/11_fulfillment/utilization/saas_user_caps_spec.rb[1:1:1:1]
Fulfillment with existing compute minutes packs behaves like Purchase storage adds additional storage to group namespace	./qa/specs/features/ee/browser_ui/11_fulfillment/purchase/purchase_storage_spec.rb[1:3:1:1]
Fulfillment with an active subscription behaves like Purchase storage adds additional storage to group namespace	./qa/specs/features/ee/browser_ui/11_fulfillment/purchase/purchase_storage_spec.rb[1:2:1:1]
Fulfillment without active subscription behaves like Purchase storage adds additional storage to group namespace	./qa/specs/features/ee/browser_ui/11_fulfillment/purchase/purchase_storage_spec.rb[1:1:1:1]

added 1 commit

b75e179f - Add empty state to pending members page

Compare with previous version

changed the description

Hey @minahilnichols

Would you review this merge request, please?

Thanks!

requested review from @minahilnichols

added Technical Writing label

approved this merge request

@fneill, thanks for approving this merge request.

This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break master, a new pipeline will be started shortly.

Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.

added pipeline:mr-approved label

E2E Test Result Summary

allure-report-publisher generated test report!

e2e-test-on-gdk: test report for a8aaafda

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Govern      | 3      | 0      | 0       | 0     | 3     | ✅     |
| Data Stores | 2      | 0      | 0       | 0     | 2     | ✅     |
| Monitor     | 4      | 0      | 0       | 0     | 4     | ✅     |
| Create      | 8      | 0      | 3       | 0     | 11    | ✅     |
| Plan        | 4      | 0      | 0       | 0     | 4     | ✅     |
| Package     | 0      | 0      | 1       | 0     | 1     | ➖     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 21     | 0      | 4       | 0     | 25    | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+

e2e-review-qa: test report for b75e179f

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Create      | 8      | 0      | 3       | 3     | 11    | ✅     |
| Govern      | 3      | 0      | 0       | 0     | 3     | ✅     |
| Data Stores | 2      | 0      | 0       | 0     | 2     | ✅     |
| Plan        | 3      | 0      | 1       | 0     | 4     | ✅     |
| Monitor     | 4      | 0      | 0       | 0     | 4     | ✅     |
| Package     | 0      | 0      | 1       | 0     | 1     | ➖     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 20     | 0      | 5       | 3     | 25    | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+

e2e-package-and-test: test report for a8aaafda

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Fulfillment | 8      | 0      | 75      | 4     | 83    | ✅     |
| Create      | 153    | 0      | 19      | 4     | 172   | ✅     |
| Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
| Plan        | 8      | 0      | 0       | 0     | 8     | ✅     |
| Govern      | 6      | 0      | 0       | 0     | 6     | ✅     |
| Data Stores | 4      | 0      | 0       | 0     | 4     | ✅     |
| Package     | 0      | 0      | 2       | 0     | 2     | ➖     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 187    | 0      | 96      | 8     | 283   | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+