Skip to content
Snippets Groups Projects

File header: Use variable instead of magic number

Merged Sascha Eggenberger requested to merge file-header-move-magic-number-to-variable into master
All threads resolved!

What does this MR do and why?

File header: Move magic number to reusable variable

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
before after
before2 after2

How to set up and validate locally

  1. Check file header in repo (e.g. http://gdk.test:3000/flightjs/Flight/-/blob/master/README.md?ref_type=heads)
  2. Check file header in an MR (e.g. http://gdk.test:3000/flightjs/Flight/-/merge_requests/3/diffs)

Related to #430972 (closed), #424397 (comment 1775253648)

Closes #430972 (closed)

Merge request reports

Merged results pipeline #1203785724 passed

Pipeline: Ruby 3.1 as-if-foss pipeline

#1203788099

    Pipeline: GitLab

    #1203792192

      Pipeline: E2E GDK

      #1203792561

        +1

        Merged results pipeline passed for 856d4b15

        Test coverage 70.05% (5.16%) from 2 jobs

        Merged by Elwyn BensonElwyn Benson 11 months ago (Mar 6, 2024 9:49pm UTC)

        Merge details

        Pipeline #1203858445 passed

        Pipeline passed for 79917d4b on master

        Test coverage 64.87% (5.16%) from 2 jobs
        6 environments impacted.

        Activity

        Filter activity
        • Approvals
        • Assignees & reviewers
        • Comments (from bots)
        • Comments (from users)
        • Commits & branches
        • Edits
        • Labels
        • Lock status
        • Mentions
        • Merge request status
        • Tracking
      • Contributor

        Bundle size analysis [beta]

        This compares changes in bundle size for entry points between the commits 7f250d68 and 6b0d3eee

        :sparkles: Special assets

        Entrypoint / Name Size before Size after Diff Diff in percent
        average 4.23 MB 4.23 MB - 0.0 %
        mainChunk 3.22 MB 3.22 MB - 0.0 %

        Note: We do not have exact data for 7f250d68. So we have used data from: e4e9106d.
        The intended commit has no webpack pipeline, so we chose the last commit with one before it.

        Please look at the full report for more details


        Read more about how this report works.

        Generated by :no_entry_sign: Danger

      • requested review from @elwyn-gitlab

      • Sascha Eggenberger removed review request for @markrian

        removed review request for @markrian

      • Sascha Eggenberger added 2929 commits

        added 2929 commits

        Compare with previous version

      • added 1 commit

        • 6b0d3eee - File header: Use variable instead of magic number

        Compare with previous version

      • Elwyn Benson approved this merge request

        approved this merge request

      • E2E Test Result Summary

        allure-report-publisher generated test report!

        e2e-test-on-gdk: :white_check_mark: test report for 6b0d3eee

        expand test summary
        +------------------------------------------------------------------+
        |                          suites summary                          |
        +-------------+--------+--------+---------+-------+-------+--------+
        |             | passed | failed | skipped | flaky | total | result |
        +-------------+--------+--------+---------+-------+-------+--------+
        | Data Stores | 31     | 0      | 0       | 0     | 31    | ✅     |
        | Package     | 24     | 0      | 2       | 0     | 26    | ✅     |
        | Verify      | 35     | 0      | 1       | 0     | 36    | ✅     |
        | Govern      | 66     | 0      | 0       | 0     | 66    | ✅     |
        | Create      | 66     | 0      | 9       | 0     | 75    | ✅     |
        | Plan        | 53     | 0      | 0       | 0     | 53    | ✅     |
        | Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
        | Monitor     | 7      | 0      | 0       | 0     | 7     | ✅     |
        | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
        | Manage      | 0      | 0      | 1       | 0     | 1     | ➖     |
        +-------------+--------+--------+---------+-------+-------+--------+
        | Total       | 289    | 0      | 13      | 0     | 302   | ✅     |
        +-------------+--------+--------+---------+-------+-------+--------+

        e2e-review-qa: :white_check_mark: test report for 6b0d3eee

        expand test summary
        +------------------------------------------------------------------+
        |                          suites summary                          |
        +-------------+--------+--------+---------+-------+-------+--------+
        |             | passed | failed | skipped | flaky | total | result |
        +-------------+--------+--------+---------+-------+-------+--------+
        | Data Stores | 2      | 0      | 0       | 0     | 2     | ✅     |
        | Govern      | 3      | 0      | 0       | 0     | 3     | ✅     |
        | Create      | 8      | 0      | 3       | 0     | 11    | ✅     |
        | Monitor     | 4      | 0      | 0       | 0     | 4     | ✅     |
        | Package     | 0      | 0      | 1       | 0     | 1     | ➖     |
        | Plan        | 3      | 0      | 1       | 0     | 4     | ✅     |
        +-------------+--------+--------+---------+-------+-------+--------+
        | Total       | 20     | 0      | 5       | 0     | 25    | ✅     |
        +-------------+--------+--------+---------+-------+-------+--------+
      • Elwyn Benson resolved all threads

        resolved all threads

      • Elwyn Benson enabled an automatic merge when the pipeline for 856d4b15 succeeds

        enabled an automatic merge when the pipeline for 856d4b15 succeeds

      • Elwyn Benson mentioned in commit 79917d4b

        mentioned in commit 79917d4b

      • Please register or sign in to reply
        Loading