File header: Use variable instead of magic number
What does this MR do and why?
File header: Move magic number to reusable variable
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
![]() |
![]() |
How to set up and validate locally
- Check file header in repo (e.g. http://gdk.test:3000/flightjs/Flight/-/blob/master/README.md?ref_type=heads)
- Check file header in an MR (e.g. http://gdk.test:3000/flightjs/Flight/-/merge_requests/3/diffs)
Related to #430972 (closed), #424397 (comment 1775253648)
Closes #430972 (closed)
Merge request reports
Activity
changed milestone to %16.10
assigned to @seggenberger
added maintenancescalability label and removed maintenanceusability label
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.Reviewer roulette
Category Reviewer Maintainer frontend @fernando-c
(UTC-6, 7 hours behind author)
@aturinske
(UTC-8, 9 hours behind author)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Elwyn BensonEdited by Sascha Eggenberger
requested review from @markrian
- Resolved by Elwyn Benson
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 7f250d68 and 6b0d3eee
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.23 MB 4.23 MB - 0.0 % mainChunk 3.22 MB 3.22 MB - 0.0 %
Note: We do not have exact data for 7f250d68. So we have used data from: e4e9106d.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangerrequested review from @elwyn-gitlab
removed review request for @markrian
added 2929 commits
-
c906f05a...e7b98aad - 2928 commits from branch
master
- 2dbd1a8f - File header: Use variable instead of magic number
-
c906f05a...e7b98aad - 2928 commits from branch
added 1 commit
- 6b0d3eee - File header: Use variable instead of magic number
added pipeline:mr-approved label
- Resolved by Elwyn Benson
@elwyn-gitlab
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 6b0d3eeeexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Data Stores | 31 | 0 | 0 | 0 | 31 | ✅ | | Package | 24 | 0 | 2 | 0 | 26 | ✅ | | Verify | 35 | 0 | 1 | 0 | 36 | ✅ | | Govern | 66 | 0 | 0 | 0 | 66 | ✅ | | Create | 66 | 0 | 9 | 0 | 75 | ✅ | | Plan | 53 | 0 | 0 | 0 | 53 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Monitor | 7 | 0 | 0 | 0 | 7 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 289 | 0 | 13 | 0 | 302 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-review-qa:
test report for 6b0d3eeeexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | | Govern | 3 | 0 | 0 | 0 | 3 | ✅ | | Create | 8 | 0 | 3 | 0 | 11 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Plan | 3 | 0 | 1 | 0 | 4 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 20 | 0 | 5 | 0 | 25 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
enabled an automatic merge when the pipeline for 856d4b15 succeeds
mentioned in commit 79917d4b
added workflowstaging label
mentioned in merge request kubitus-project/kubitus-installer!2869 (merged)
added releasedpublished label
added pipelinetier-3 label
added devopsmanage label