Use service response shared examples in test Npm::CreatePackageService
requested to merge gitlab-community/gitlab:323970-gerardo-navarro-protected-packages-npm-create-package-service-return-service-response-follow-up-use-service-response-shared-exmaples into master
What does this MR do and why?
- Using the existing shared examples for service response to avoid code duplication
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
MR Checklist (@gerardo-navarro)
-
Changelog entry added, if necessary -
Documentation created/updated via this MR -
Documentation reviewed by technical writer or follow-up review issue created -
Tests added for this feature/bug -
Tested in all supported browsers -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the javascript style guides -
Conforms to the database guides
Screenshots or screen recordings
No frontend . Only backend changes.
How to set up and validate locally
- Execute tests
bundle exec rspec spec/services/packages/npm/create_package_service_spec.rbRelated to #323970
Edited by Gerardo Navarro