Fix usage of shared example in test Pypi::CreatePackageService
requested to merge gitlab-community/gitlab:427546-gerardo-navarro-pypi-create-package-service-return-service-response-follow-up-wrong-shared-example-usage into master
What does this MR do and why?
- Fixing the wrong usage of shared example 'returning an error service response' , see https://gitlab.com/gitlab-community/gitlab/-/blob/fdf61409f4e8ad44118cd82e987ad76045ef37a6/spec/support/shared_examples/services/service_response_shared_examples.rb#L3
- Currently in the test file
Pypi::CreatePackageService, the assertion related to the param:messageis ignored because it is passed in the wrong way
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
MR Checklist (@gerardo-navarro)
-
Changelog entry added, if necessary -
Documentation created/updated via this MR -
Documentation reviewed by technical writer or follow-up review issue created -
Tests added for this feature/bug -
Tested in all supported browsers -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the javascript style guides -
Conforms to the database guides
Screenshots or screen recordings
No frontend changes. Only backend changes.
How to set up and validate locally
- Just execute the test
bundle exec rspec spec/services/packages/pypi/create_package_service_spec.rbRelated to #427546
Edited by Gerardo Navarro