Skip to content

Revert "Merge branch '434826-fix-boolean-and-number-type-inputs'

Furkan Ayhan requested to merge revert-296b2b3d into master

Purpose of revert

This reverts merge request !144065 (merged)

first reported: https://gitlab.slack.com/archives/C019R5JD44E/p1708331108318259

This test does not work in the new code;

spec/lib/gitlab/ci/config/interpolation/interpolator_spec.rb =>

  context 'when multiple interpolation is valid' do
    let(:header) do
      { spec: { inputs: { a: nil, b: nil, c: nil } } }
    end

    let(:content) do
      { test: 'deploy $[[ inputs.a ]] $[[ inputs.b ]] $[[ inputs.c ]]' }
    end

    let(:arguments) do
      { a: 'a', b: 'b', c: 'c' }
    end

    it 'correctly interpolates the config' do
      subject.interpolate!

      expect(subject).to be_interpolated
      expect(subject).to be_valid
      expect(subject.to_hash).to eq({ test: 'deploy a b c' })
    end
  end

Milestone info

  • I am reverting something in the current milestone. No changelog is needed, and I've added a ~"regression:*" label.
  • [] I am reverting something in a different milestone. A changelog is needed, and I've removed the ~"regression:*" label.

Related issues and merge requests

Edited by Furkan Ayhan

Merge request reports