Skip to content

Use entity full_path for page title / breadcrumbs

Justin Ho Tuan Duong requested to merge 441416-more-informative-breadcrumbs-on-import-result-pages into master

What does this MR do and why?

Instead of using just the id, we now use full_path which is provided by the backend. We also add a fallback in case the project / group failed to be created.

Changelog: changed

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
Failures_with_full_path_before_1 Failures_with_full_path_after_1
Failures_with_full_path_before_2 Failures_with_full_path_after_2

How to set up and validate locally

Import groups by direct transfer

  1. On the left sidebar, at the top, select Create new... (+) and New group. Then select Import group.
  2. In GitLab source instance base URL, enter your GDK URL. For example, http://127.0.0.1:3000.
  3. In Personal access token, enter a token from your GDK.
  4. Select Connect instance.
  5. Apply the following diff to make some import items fail intentionally:
diff --git a/lib/bulk_imports/ndjson_pipeline.rb b/lib/bulk_imports/ndjson_pipeline.rb
index 07118c3b55c0..5988e998afd2 100644
--- a/lib/bulk_imports/ndjson_pipeline.rb
+++ b/lib/bulk_imports/ndjson_pipeline.rb
@@ -35,6 +35,8 @@ def transform(context, data)
       end
 
       def load(_context, object)
+        raise StandardError.new('Error!')
+
         return unless object
 
         if object.new_record?
  1. Start a few imports with any group and let them run.
  2. Click on the History link on the upper right corner to view the history page. For example, http://127.0.0.1:3000/import/bulk_imports/history.
  3. Find an import item with failures and click the See failures link in the status column.
  4. You should be on the Failures page. For example, http://127.0.0.1:3000/import/bulk_imports/121/history/63/failures.

Related to #441416 (closed)

Merge request reports