Protected packages: Return ServiceResponse for CreateMavenPackageService
requested to merge gitlab-community/gitlab:323969-gerardo-navarro-protected-packages-maven-create-package-service-return-service-response into master
What does this MR do and why?
- Returning a successful
ServiceResponseas suggested by the best-practice documentation, see https://docs.gitlab.com/ee/development/reusing_abstractions.html#serviceresponse - Exceptions raised in
Packages::Maven::CreatePackageServicehave been transformed to erroneous service response - This MR follows the same approach as in another MR related to npm packages
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
MR Checklist (@gerardo-navarro)
-
Changelog entry added, if necessary -
Documentation created/updated via this MR -
Documentation reviewed by technical writer or follow-up review issue created -
Tests added for this feature/bug -
Tested in all supported browsers -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the javascript style guides -
Conforms to the database guides
Screenshots or screen recordings
Only backend changes. No frontend changes.
How to set up and validate locally
- Execute the relevant tests
bundle exec rspec spec/requests/api/maven_packages_spec.rb ee/spec/requests/api/maven_packages_spec.rb spec/services/packages/maven/create_package_service_spec.rbRelated to #323969
Edited by Gerardo Navarro