Update filtered search bar tests for vue 3
What does this MR do and why?
Update filtered search bar tests for vue 3
- bring them partially up to current standards
- remove vue 3 deprecated patterns
- reimplement !144947 (merged), but fix the issue with
the FOSS tests by changing storage key to one in CE
- previously the storage key
requirements
was used in the test, but that is only available in EE - the second commit is the fix
- previously the storage key
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Related to #391171
Related to !144947 (merged)
Merge request reports
Activity
assigned to @aturinske
changed milestone to %16.10
Reviewer roulette
Category Reviewer Maintainer frontend @agulina
(UTC+1, 8 hours ahead of author)
@tbulva
(UTC+1, 8 hours ahead of author)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Paul Slaughter
@pslaughter can you review this? the first commit is what was reverted and the second commit is the changes to ensure FOSS tests pass as well. See !145070 (comment 1778064765) for a full analysis
Additionally, the jest predictive as-if-foss job passed this time where it failed last time
requested review from @pslaughter
- Resolved by Paul Slaughter
- Resolved by Paul Slaughter
- Resolved by Paul Slaughter
- Resolved by Paul Slaughter
Thanks for working on this @aturinske! I left some small questions for your consideration. Back to you!
removed review request for @pslaughter
requested review from @pslaughter
I tested the
FOSS_ONLY=1
of this test and it looks like we're good to go. Thanks for working on this @aturinske! Changes LGTMApproving and starting merge...
- Resolved by Paul Slaughter
@pslaughter
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
added pipeline:mr-approved label
enabled an automatic merge when the pipeline for 365e8ee3 succeeds
mentioned in commit 003ab37c
mentioned in commit 5b783fd9
added workflowstaging-canary label and removed workflowready for development label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
added pipelinetier-3 label