Skip to content
Snippets Groups Projects

Update filtered search bar tests for vue 3

Merged Alexander Turinske requested to merge 391171-update-filtered-search-tests-ce into master
All threads resolved!

What does this MR do and why?

Update filtered search bar tests for vue 3

  • bring them partially up to current standards
  • remove vue 3 deprecated patterns
  • reimplement !144947 (merged), but fix the issue with the FOSS tests by changing storage key to one in CE
    • previously the storage key requirements was used in the test, but that is only available in EE
    • the second commit is the fix

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
image image

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Related to #391171

Related to !144947 (merged)

Edited by Alexander Turinske

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • @pslaughter can you review this? the first commit is what was reverted and the second commit is the changes to ensure FOSS tests pass as well. See !145070 (comment 1778064765) for a full analysis

    Additionally, the jest predictive as-if-foss job passed this time where it failed last time

  • requested review from @pslaughter

  • Looking at this now! :eyes:

  • Paul Slaughter
  • Paul Slaughter
  • Paul Slaughter
  • Paul Slaughter removed review request for @pslaughter

    removed review request for @pslaughter

  • requested review from @pslaughter

  • Paul Slaughter resolved all threads

    resolved all threads

  • Paul Slaughter approved this merge request

    approved this merge request

  • I tested the FOSS_ONLY=1 of this test and it looks like we're good to go. Thanks for working on this @aturinske! Changes LGTM :thumbsup:

    lgtm

    Approving and starting merge...

  • Paul Slaughter resolved all threads

    resolved all threads

  • Paul Slaughter enabled an automatic merge when the pipeline for 365e8ee3 succeeds

    enabled an automatic merge when the pipeline for 365e8ee3 succeeds

  • merged

  • Paul Slaughter mentioned in commit 003ab37c

    mentioned in commit 003ab37c

  • mentioned in commit 5b783fd9

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading