Skip to content

Update modal with new options

Alexander Turinske requested to merge 441456-improve-spp-modal into master

What does this MR do and why?

Update modal with new options

  • change text
  • add description
  • update queries for security policy projects (SPP)
  • add toggle to limit search for existing SPPs or not
  • clear project selection on link failure
  • update modal to show initially selected project if a user changes the selection but does not save

Changelog: changed

EE: true

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
image image after

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Upload a GitLab Ultimate license
  2. Navigate to a group/project => Secure => Policies => Edit project policy => Select a project (this selected project is now designated as a security policy project (SPP) )
  3. Navigate to new SPP and add the user as a reporter
  4. Navigate to a different group/project
  5. Add user as Owner
  6. Navigate to Secure => Policies => Edit project policy
  7. Verify new modal can change change projects
  8. Verify if the user toggles to only show security policy projects, when the user searches for a project, only security policy projects appear
  9. Verify if the user toggle to not only show security policy projects, when the user searches for a project, non-security policy projects appear
  10. Verify the user can link an SPP
  11. Verify the user can unlink an SPP
  12. Link the SPP the user is reporter in
  13. Navigate to the SPP and remove membership
  14. Navigate back to group/project => Secure => Policies => Edit policy project
  15. Verify the user can relink/remove the SPP

Related to #441456 (closed)

Edited by Alexander Turinske

Merge request reports