Skip to content

Fix popover implementation spacing when no title present

Changelog: fixed

What does this MR do and why?

GitLab adds some clever stuff to GlPopover to make it JustWork in a bunch of files.

This change prevents the title field being populated, and unnecessary space rendered, if there is no title.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
Screenshot_2024-02-16_at_13.48.01 Screenshot_2024-02-16_at_13.48.22

How to set up and validate locally

  1. Find a popover without a title, for example the following on the admin dashboard http://127.0.0.1:3000/admin
    Screenshot_2024-02-16_at_13.55.26
  2. See the space, and marvel at its balance

Closes #442183 (moved)

Edited by Dan Mizzi-Harris

Merge request reports