Skip to content
Snippets Groups Projects

Show deployment approval comments

Merged Andrew Fontaine requested to merge afontaine/374538/approval-timeline into master
All threads resolved!

What does this MR do and why?

Adds a notable-style comment timeline for deployment approvals.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

image

I know, we should add a column in this table for Rejections. I'll follow-up with that in another MR.

image

How to set up and validate locally

  1. Enable the feature flag deployment_details_page
  2. Add the following GitLab CI Yaml to a project
Click to expand
stages:
    - deploy
    - stop
image: alpine:latest

deploy-prod:
    stage: deploy
    script:
        - sleep 10
        - echo "deploying prod"
    environment:
        name: production
        url: postgres://example.com

deploy-staging:
    stage: deploy
    script:
        - echo "deploying staging I hope"
    environment:
        name: staging
        url: https://example.com
        on_stop: stop-staging
    when: manual

stop-staging:
  stage: stop
  script:
    - echo "stopping staging"
    - sleep 600
  environment:
    name: staging
    action: stop
  when: manual

deploy-development:
    stage: deploy
    script:
        - echo "deploying development"
    environment:
        name: development
        url: https://example.com
    when: manual

deploy-review:
    stage: deploy
    script:
        - echo "Deploying review/$CI_COMMIT_REF_NAME"
    environment:
        name: review/$CI_COMMIT_REF_NAME
        auto_stop_in: 1 week
    only:
        - branches
    except:
        - master
    when: manual


stop_review_app:
  script: stop-review-app
  stage: stop
  environment:
    name: review/$CI_COMMIT_REF_SLUG
    action: stop
  rules:
    - if: $CI_MERGE_REQUEST_ID
      when: manual
  1. Run pipelines to create environments/deployments
  2. Protect the Production environment by navigating to Settings > CI/CD and add at least one deployment rule and at least one approval rule.
  3. Run another pipeline.
  4. Navigate to http://<gdk-url>/<namespace>/<project>/-/environments/<environment id>/deployments/<deployment iid>

For #374538 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • requested review from @partiaga and @andrei.zubov

  • Pam Artiaga approved this merge request

    approved this merge request

  • Pam Artiaga requested review from @tkuah and removed review request for @partiaga

    requested review from @tkuah and removed review request for @partiaga

  • Thong Kuah approved this merge request

    approved this merge request

  • Thong Kuah removed review request for @tkuah

    removed review request for @tkuah

  • Andrei Zubov requested review from @anna_vovchenko

    requested review from @anna_vovchenko

  • added 1 commit

    • a6c1ced7 - Remove page specific styles for deployments

    Compare with previous version

  • Andrew Fontaine reset approvals from @tkuah by pushing to the branch

    reset approvals from @tkuah by pushing to the branch

  • requested review from @anna_vovchenko

  • mentioned in issue #443526 (closed)

  • Anna Vovchenko approved this merge request

    approved this merge request

  • Anna Vovchenko resolved all threads

    resolved all threads

  • Anna Vovchenko enabled an automatic merge when the pipeline for b5ed772e succeeds

    enabled an automatic merge when the pipeline for b5ed772e succeeds

  • mentioned in commit 6b33aac9

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading