Show deployment approval comments
What does this MR do and why?
Adds a notable-style comment timeline for deployment approvals.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
I know, we should add a column in this table for Rejections. I'll follow-up with that in another MR.
How to set up and validate locally
- Enable the feature flag
deployment_details_page
- Add the following GitLab CI Yaml to a project
Click to expand
stages:
- deploy
- stop
image: alpine:latest
deploy-prod:
stage: deploy
script:
- sleep 10
- echo "deploying prod"
environment:
name: production
url: postgres://example.com
deploy-staging:
stage: deploy
script:
- echo "deploying staging I hope"
environment:
name: staging
url: https://example.com
on_stop: stop-staging
when: manual
stop-staging:
stage: stop
script:
- echo "stopping staging"
- sleep 600
environment:
name: staging
action: stop
when: manual
deploy-development:
stage: deploy
script:
- echo "deploying development"
environment:
name: development
url: https://example.com
when: manual
deploy-review:
stage: deploy
script:
- echo "Deploying review/$CI_COMMIT_REF_NAME"
environment:
name: review/$CI_COMMIT_REF_NAME
auto_stop_in: 1 week
only:
- branches
except:
- master
when: manual
stop_review_app:
script: stop-review-app
stage: stop
environment:
name: review/$CI_COMMIT_REF_SLUG
action: stop
rules:
- if: $CI_MERGE_REQUEST_ID
when: manual
- Run pipelines to create environments/deployments
- Protect the Production environment by navigating to Settings > CI/CD and add at least one deployment rule and at least one approval rule.
- Run another pipeline.
- Navigate to
http://<gdk-url>/<namespace>/<project>/-/environments/<environment id>/deployments/<deployment iid>
For #374538 (closed)
Merge request reports
Activity
changed milestone to %16.10
added feature flag groupenvironments typefeature labels
assigned to @afontaine
added devopsdeploy sectioncd labels
1 Warning This merge request contains lines with testid selectors. Please ensure e2e:package-and-test
job is run.1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
testid
selectorsThe following changed lines in this MR contain
testid
selectors:ee/app/assets/javascripts/deployments/components/deployment_timeline.vue
+ :data-testid="`approval-${approval.user.username}`"
If the
e2e:package-and-test
job in theqa
stage has run automatically, please ensure the tests are passing. If the job has not run, please start thetrigger-omnibus-and-follow-up-e2e
job in theqa
stage and ensure the tests infollow-up-e2e:package-and-test-ee
pipeline are passing.For the list of known failures please refer to the latest pipeline triage issue.
If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.
Reviewer roulette
Category Reviewer Maintainer frontend @sheldonled
(UTC+0, 5 hours ahead of author)
@ekigbo
(UTC+11, 16 hours ahead of author)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits f7f08e9f and a6c1ced7
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.21 MB 4.21 MB - -0.0 % mainChunk 3.21 MB 3.21 MB - 0.0 %
Note: We do not have exact data for f7f08e9f. So we have used data from: 40dc9717.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerE2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for a6c1ced7expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Data Stores | 31 | 0 | 0 | 0 | 31 | ✅ | | Govern | 66 | 0 | 0 | 1 | 66 | ✅ | | Monitor | 7 | 0 | 0 | 0 | 7 | ✅ | | Package | 24 | 0 | 2 | 0 | 26 | ✅ | | Create | 66 | 0 | 9 | 0 | 75 | ✅ | | Verify | 35 | 0 | 1 | 0 | 36 | ✅ | | Plan | 53 | 0 | 0 | 0 | 53 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 289 | 0 | 13 | 1 | 302 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
- Resolved by Anna Vovchenko
- Resolved by Anna Vovchenko
@partiaga mind reviewing the (small) backend changes?
@andrei.zubov can I get you to review the frontend here?
requested review from @partiaga and @andrei.zubov
- Resolved by Andrew Fontaine
@partiaga
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
added pipeline:mr-approved label
removed review request for @tkuah
- Resolved by Andrew Fontaine
requested review from @anna_vovchenko
- Resolved by Anna Vovchenko
[question] @afontaine I've noticed that the page does not refresh when you click any action button. Do you plan to fix it in another MR? If yes, is there an issue for it?
- Resolved by Andrew Fontaine
- Resolved by Andrew Fontaine
- Resolved by Andrew Fontaine
reset approvals from @tkuah by pushing to the branch
requested review from @anna_vovchenko
mentioned in issue #443526 (closed)
enabled an automatic merge when the pipeline for b5ed772e succeeds
mentioned in commit 6b33aac9
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedpublished label and removed releasedcandidate label
added pipelinetier-3 label