Skip to content

Environment scope should not reorder whole query

Thong Kuah requested to merge fix_environment_scope_to_not_reorder into master

What does this MR do?

Environment scope should not reorder whole query. Rather, only reverse the ORDER clause for this relation

E.g. I expect:

scope.order(my_order ASC).on_environment(environment, relevant_only: true)

to retain my first ASC order.

(First noticed in https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/14480)

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports