Skip to content

Extract vulnerabilities actions from group security vulnerabilities controller

What does this MR do?

This MR extracts vulnerabilities actions from Groups::Security::VulnerabilitiesController that it will have in common with the soon-to-come Projects::Security::VulnerabilitiesController.

This is the 3rd MR towards decoupling the project security dashboard from the group security dashboard's vulnerabilities endpoints. The other two are https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/14472 and https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/14471. It must be merged after https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/14471.

The coupling of the dashboard's endpoints has resulted in a few bugs: https://gitlab.com/gitlab-org/gitlab-ee/issues/12381, https://gitlab.com/gitlab-org/gitlab-ee/issues/12244

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports