Skip to content

Vagueifies the group templates count for performance

Robert May requested to merge nobble-new-project-template-counters into master

What does this MR do and why?

Removes the accuracy of the group templates count when the :project_templates_without_min_access feature flag is enabled. It now shows only an indicator that there is more than 1 template, or 0. This resolves a major performance problem caused by checking permissions for hundreds of group template projects in a loop until we can heavily rework some of the auth code to be more performant.

Related #441462

This is related to the following rollout: #425452 (closed). The rollout of this feature is more important than accurate counters. However the queries this skips may then be executed again by the code used to show the list, so it's unclear yet as to whether this fully resolves the issue.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests. Screenshot_2024-02-13_at_11.32.22

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Robert May

Merge request reports