Skip to content

Prevent outdated deployment checks for invalid deployments

drew stachon requested to merge 431956-no-method-error-on-invalid-deployments into master

What does this MR do and why?

This MR fixes an error we see somewhat often in Sentry when a Deployment record doesn't have an ID. I have assumed this is because the record is invalid, and have added a test using an invalid record to reproduce the exact error message and then make a small change to prevent it.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

Mostly using the specs.

  1. Take a look at the linked error in Sentry
  2. Check out the source branch and uncomment the logic changes, leaving the spec in place.
  3. Run the spec, seeing that it produces the exact failure we see a few thousand times every month in Sentry
  4. Uncomment the application logic changes and run the specs again.

How to Validate in Production

  1. See the errors go to (roughly?) 0 in Kibana
  2. See the errors go to (roughly?) 0 in Sentry

Related to #431956 (closed)

Edited by drew stachon

Merge request reports