Refactor GroupMembersFinder to move ActiveRecord method usage to model
What does this MR do and why?
Refactor GroupMembersFinder to move ActiveRecord method usage to model
Here we're moving the usage of the joins
method to the Member
model
the resulting code is easier to read.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Query plans
It's just refactoring so there's no change in query. If you want to see the query plans see !115346 (merged).
How to set up and validate locally
Run the specs spec/finders/group_members_finder_spec.rb
.
Related to #389052 (closed)
Edited by Abdul Wadood