Skip to content

Migrate some commits styles to a page-specific CSS bundle

Paul Gascou-Vaillancourt requested to merge 239804-commits-page-specific-css-bundle-part-1 into master

What does this MR do and why?

Migrate some commits styles to a page-specific CSS bundle

This migrates commits lists styles to a page-specific CSS bundle. Those styles are used in projects' commits list as well as in merge requests commits.

The migration is done behind a feature flag. In the next iteration, we'll move this first part out of the feature flag guard, and we'll migrate remaining styles to another page-specific bundle as what remains is specific to a single commit's details.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

No visual diff.

How to set up and validate locally

  1. In rails console enable the :page_specific_styles feature flag. 
    Feature.enable(:page_specific_styles)
  2. Visit a project's commits page eg http://gdk.test:3000/flightjs/Flight/-/commits/master?ref_type=heads
  3. Visit an MR's commits tab.
  4. Visit a file's history eg http://gdk.test:3000/twitter/Typeahead.Js/-/commits/master/Gruntfile.js

Related to #239804

Edited by Paul Gascou-Vaillancourt

Merge request reports