Skip to content

Rename saas only feature google_artifact_registry

David Fernandez requested to merge 438989-rename-saas-only-feature into master

🎈 Context

In Adds menu entry for Google Artifact registry (!140086 - merged), we introduced a saas only feature gate: google_artifact_registry.

At that time, we were targeting the Google Cloud Artifact Registry support, hence the name.

As the Google Cloud support was being implemented, other services than the Artifact Registry were supported too. As we didn't have a reason to create a new saas only feature gate each time, we used the same one: google_artifact_registry.

This leads us to the current situation as of the time of this writing: different Google Cloud services support are gated behind a feature name called google_artifact_registry.

This MR aims to correct this by renaming the saas only feature name to google_cloud_support. This is issue Rename SaaS only feature name: google_artifact_... (#438989 - closed).

🤔 What does this MR do and why?

  • Rename the saas only gate from google_artifact_registry to google_cloud_support.
  • Update all the related code and specs.

Please note that this has no impact on the existing behaviors. If there is an impact, that should be considered as a typebug.

🚀 MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

📺 Screenshots or screen recordings

This is a backend refactoring so uh well, no UI changes.

How to set up and validate locally

Well, we have many aspects in the code that are gated behind this saas only feature, so we don't really have one single test scenario. Here are what you can try:

Edited by David Fernandez

Merge request reports