Skip to content

Ignore RSpec::Parameterized deprecation warning only in Ruby 3.1

Peter Leitzen requested to merge pl-ruby-3-2-deprecation-warning into master

What does this MR do and why?

Also remove the warning to suggest dropping the ignore for Ruby 3.2. It's noisy and unnecessary.

See !114447 (comment 1759196764).

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

Run bundle exec rspec --dry-run --format progress spec/models/namespace_ci_cd_setting_spec.rb to ensure the lack of deprecation warning in all 3 supported Ruby versions:

Ruby 3.0

$ ruby -v && bundle exec rspec --dry-run --format progress  spec/models/namespace_ci_cd_setting_spec.rb
ruby 3.0.6p216 (2023-03-30 revision 23a532679b) [x86_64-linux]
[TEST PROF INFO] FactoryDoctor enabled (event: "sql.active_record", threshold: 0.01)
[TEST PROF INFO] FactoryProf enabled (simple mode)
[TEST PROF INFO] RSpecDissect enabled
Run options: include {:focus=>true}

All examples were filtered out; ignoring {:focus=>true}

Randomized with seed 50349
..

Finished in 0.00121 seconds (files took 22.23 seconds to load)
2 examples, 0 failures

Randomized with seed 50349

[TEST PROF INFO] No factories detected

Ruby 3.1

$ ruby -v && bundle exec rspec --dry-run --format progress  spec/models/namespace_ci_cd_setting_spec.rb
ruby 3.1.4p223 (2023-03-30 revision 957bb7cb81) [x86_64-linux]
[TEST PROF INFO] FactoryDoctor enabled (event: "sql.active_record", threshold: 0.01)
[TEST PROF INFO] FactoryProf enabled (simple mode)
[TEST PROF INFO] RSpecDissect enabled
Run options: include {:focus=>true}

All examples were filtered out; ignoring {:focus=>true}

Randomized with seed 52471
..

Finished in 0.00151 seconds (files took 14.29 seconds to load)
2 examples, 0 failures

Randomized with seed 52471

[TEST PROF INFO] No factories detected

Ruby 3.2

$ ruby -v && bundle exec rspec --dry-run --format progress  spec/models/namespace_ci_cd_setting_spec.rb
ruby 3.2.3 (2024-01-18 revision 52bb2ac0a6) [x86_64-linux]
[TEST PROF INFO] FactoryDoctor enabled (event: "sql.active_record", threshold: 0.01)
[TEST PROF INFO] FactoryProf enabled (simple mode)
[TEST PROF INFO] RSpecDissect enabled
warning: parser/current is loading parser/ruby32, which recognizes 3.2.2-compliant syntax, but you are running 3.2.3.
Please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.
Run options: include {:focus=>true}

All examples were filtered out; ignoring {:focus=>true}

Randomized with seed 45474
..

Finished in 0.00089 seconds (files took 23 seconds to load)
2 examples, 0 failures

Randomized with seed 45474

[TEST PROF INFO] No factories detected
Edited by Peter Leitzen

Merge request reports