Fix YAML VSD settings overriding default (!143786) · Merge requests · GitLab.org / GitLab

What does this MR do and why?

Fix YAML VSD settings overriding default

Ensures the default built in VSD configuration is not overridden by YAML configured VSD when the group_analytics_dashboard_dynamic_vsd feature flag is enabled. Also fixes the error that displays when attempting to view the YAML configured VSD with the feature flag enabled.

The overriding behaviour is still needed when the feature flag is disabled.

Testing instructions

Please make sure that you have a GitLab Ultimate license

group_analytics_dashboard_dynamic_vsd - DISABLED

Create a group or select an existing one
- Ensure the group has at least 2 projects, one we will use for customization
Navigate to Analyze > Analytics Dashboards in the left hand menu
Select Value streams dashboard from the dashboard list, the dashboard should render
Follow the instructions to add a YAML configuration for the group
- Update the title and data.namespace fields to reflect the projects in your group
- Once the YAML config is configured, return to Analyze > Analytics Dashboards, there should still be a single dashboard (Value Streams Dashboard), selecting the dashboard should render with any changes you made to the config

group_analytics_dashboard_dynamic_vsd - ENABLED

Enable the group_analytics_dashboard_dynamic_vsd feature flag, this will render VSD as an analytics dashbaord
```
$ Feature.enable(:group_analytics_dashboard_dynamic_vsd)
```
Navigate to Analyze > Analytics Dashboards in the left hand menu
There will be 2 dashboards available in the dashboard list (Value Streams Dashboard + Your custom YAML dashboard)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.