Skip to content

Refactor common metrics importer

Ryan Cobb requested to merge 63044-cluster-health-group-refactor into master

What does this MR do?

EE side of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/30012

Issue: https://gitlab.com/gitlab-org/gitlab-ce/issues/63044

This MR refactors our common_metrics importer into a new pattern. This is done for a couple of reasons:

  1. It allows us to more easily extend classes/modules for EE.
  2. It establishes a new pattern that will help prevent class/module collision if/when we create more importers beyond common_metrics.
  3. It moves code to lib/gitlab so we don't need to explicitly require the importers.

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports