Skip to content

Move ProtectedBranch::CacheService#refresh logic

Joe Woodward requested to merge chore/move-protected_branch-caching-logic-into-cache_service into master

What does this MR do and why?

Move ProtectedBranch::CacheService#refresh logic

Prior to this we implemented logic to refresh the cache correctly in the BaseService by looping over a Group's Projects when we refresh the Group's cache. This meant that it was possible to bypass this logic when calling the CacheService directly.

This change moves the logic for refreshing the cache for a group's projects into the cache service to ensure they are always refreshed when a group is refreshed.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Merge request reports