Skip to content

Use SubscriptionHelper for SaaS checks when creating member roles

Hinam Mehra requested to merge 438360-use-subscription-helper-member-roles into master

What does this MR do and why?

  • Use SubscriptionHelper for SaaS checks when creating member roles. SubscriptionHelper has a method, gitlab_com_subscription? to check if the application is in SaaS mode, which means we can replace the existing Gitlab::Saas.feature_available?(:group_custom_roles) check we have when creating/fetching member roles with that method.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

No change

How to set up and validate locally

  1. Simulate SaaS mode with
export GITLAB_SIMULATE_SAAS=1
  1. Navigate to any group that you are an owner of, then go to Settings -> Roles and Permissions.
  2. Then click on Add a role and complete the form to create a new role.

Related to #438360 (closed)

Edited by Hinam Mehra

Merge request reports