Skip to content

Migrate total metric to internal events and keep legacy key

Piotr Skorupa requested to merge psk-migrate-count-to-internal-events-without-redis-migration into master

What does this MR do and why?

Related to #429556 (closed).

This migrates the counts.web_ide_views total count metric to Internal Events, while keeping the original Redis key. Instead of migrating the key to the new format in TotalCountMetric, the new key is aliased in a YAML file and points to the old one, so that the count continues in the old key and we can keep the past count.

Adding the YAML file also lays the groundwork for migrating the rest of the total count metrics.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

  1. Checkout master and fire the event a few times (open the Web IDE).
  2. Run in console and note the value:
definition = Gitlab::Usage::MetricDefinition.definitions['counts.web_ide_views']
Gitlab::Usage::Metric.new(definition).with_value
  1. Checkout MR branch and run the code in the console again. The value should be identical.
  2. Fire the event a few more times and check if the value got incremented.
Edited by Piotr Skorupa

Merge request reports