Skip to content

Combine json-schemas for metrics into a single file

Sarah Yasonik requested to merge sy-combine-metrics-schema into master

What does this MR do and why?

  • Changes: Rewrites lib/gitlab/usage/metric_definition.rb to validate metric definitions against a single schema.
  • Motivation: This simplifies the process of validating metric definitions from multiple locations.

Used in Show user validation errors after generating ev... (!143433 - merged) & Add specs to validate that Internal Events CLI ... (!143430 - merged)

Related issue: #441143 (closed)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

  1. Run Gitlab::Usage::MetricDefinition.definitions.values.map { puts _1.validation_errors }; 0 in rails console & ensure that no errors are logged
Edited by Sarah Yasonik

Merge request reports