Skip to content

Refactor Google Cloud client classes

Pedro Pombeiro requested to merge pedropombeiro/439569/refactor-client-classes into master

What does this MR do and why?

After the introduction of a new client in !143099 (merged), there's an opportunity to refactor the Google Cloud client classes to minimize duplication and maximize reuse.

This is done in these main ways:

  • Move gcp_project_id and gcp_wlif to the base client.
  • Move BLANK_PARAMETERS_ERROR_MESSAGE check to base class.
  • Move SAAS_ONLY_ERROR_MESSAGE check to base class.
  • Move handling_errors and related error classes to base class.

EE: true

Part of #439569 (closed)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

n/a

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

n/a

Edited by Pedro Pombeiro

Merge request reports