You need to sign in or sign up before continuing.
Move `derailed_benchmarks` gem to default group
What does this MR do?
For compatibility with CE: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/29975
Some benchmarks of the gem require booting the app in production
environment.
Having derailed_benchmarks
in the :default
group will eliminate additional steps to run derailed exec
.
Example when we need it: https://gitlab.com/gitlab-org/gitlab-ce/issues/62747#note_178622307
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Aleksei Lipniagov