Skip to content

Fix TeamCity integration not executing when MR created

Luke Duncalfe requested to merge 327452-fix-teamcity-and-drone-integrations-not-working-with-mr-create into master

What does this MR do and why?

In !56086 (merged) a merge request's merge_state was changed to be "preparing" when created.

This change updates the checks within PushDataValidations to consider this merge_state to be one where the Team City and Drone CI integrations should execute #327452 (comment 588598735).

#327452 (closed)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

  1. Switch to this branch and restart your background worker: gdk restart rails-background-jobs.
  2. Set up a new Team City integration:
    1. Choose a project, and go Settings > Integrations and choose JetBrains TeamCity.
    2. For Trigger, choose Merge request and ensure Push is NOT selected.
    3. For the server URL, visit https://webhook.site and use the "unique URL".
    4. For Build name, Username and Password enter any details.
  3. Keep a tab with https://webhook.site open.
  4. Create a new MR. https://webhook.site should receive a webhook (meaning, the integration executed).

Related to #327452 (closed)

Edited by Luke Duncalfe

Merge request reports