Skip to content

Remove archived projects from the group vulnerability report filter

What does this MR do and why?

This MR uses the includeArchived: false filter to exclude archived projects from the filter list on the group-level vulnerabilities dashboard

Context

We do not include archived projects in the group-level vulnerabilities report (e.g. in the summary counts, in the list of vulnerabilities).

However, archived projects show up in the project filter as an option to filter by.

A new filter param, includeArchived, was added to the groupProjects graphql resolver used by this filter in:

  1. Add `includeArchived: true | false` to `groupPr... (!142396 - merged) • Michael Becker • 16.9
  2. Add `include_archived` param to the `Namespaces... (!141989 - merged) • Michael Becker • 16.9

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
before after

How to set up and validate locally

  1. Import the webgoat project into your local gdk under a group

    1. the group I use in this example is http://gdk.test:3000/gitlab-org
    2. We will be archiving this project, so if you already have it imported maybe name it "Archived Webgoat.Net" to make it easy to distinguish in the project filter dropdown (this is the name I use in this example)
  2. Archive the project

    1. e.g. http://gdk.test:3000/gitlab-org/archived-webgoat.net/edit
  3. now view the group level vulnerability report for the group you imported this project under

    1. e.g. http://gdk.test:3000/groups/gitlab-org/-/security/vulnerabilities
  4. When you click the projects filter drop-down, you will see our archived project as an option

    1. this is the bug: archived projects should not be included in the group-level report view
    example
    image.png
  5. With the MR's branch checked out, you should not see the archived project in the filter list

Related to #426520 (closed)

Edited by Michael Becker

Merge request reports