Skip to content

Fix scope for Packages module.

Tyler Amos requested to merge fix-packages-scope-in-ee-fixtures into master

What does this MR do?

DISCLAIMER: This is my first MR and haven't finished reading through all the docs yet. Please be gentle when reviewing. 🙏 😄

As part of onboarding, I was trying to install gdk-ee on my new MacBook and ran into the following error during execution of the gdk install gitlab_repo=https://gitlab.com/gitlab-org/gitlab-ee.git command.

== Seed from ee/db/fixtures/development/26_packages.rb
rake aborted!
NameError: uninitialized constant Gitlab::Seeder::Packages::Packages
(eval):19:in `block in seed'
(eval):9:in `times'
(eval):9:in `seed'
(eval):36:in `block (4 levels) in run_file'
(eval):35:in `each'
(eval):35:in `block (3 levels) in run_file'
/Users/tyler/apps/gdk-ee/gitlab/lib/gitlab/seeder.rb:23:in `quiet'
(eval):34:in `block (2 levels) in run_file'
/Users/tyler/apps/gdk-ee/gitlab/lib/tasks/gitlab/setup.rake:36:in `setup_db'
/Users/tyler/apps/gdk-ee/gitlab/lib/tasks/gitlab/setup.rake:5:in `block (2 levels) in <main>'
/Users/tyler/apps/gdk-ee/gitlab/lib/tasks/dev.rake:7:in `block (2 levels) in <main>'
/Users/tyler/.rbenv/versions/2.6.3/bin/bundle:23:in `load'
/Users/tyler/.rbenv/versions/2.6.3/bin/bundle:23:in `<main>'

Caused by:
NameError: uninitialized constant Gitlab::Seeder::Packages::Packages
(eval):19:in `block in seed'
(eval):9:in `times'
(eval):9:in `seed'
(eval):36:in `block (4 levels) in run_file'
(eval):35:in `each'
(eval):35:in `block (3 levels) in run_file'
/Users/tyler/apps/gdk-ee/gitlab/lib/gitlab/seeder.rb:23:in `quiet'
(eval):34:in `block (2 levels) in run_file'
/Users/tyler/apps/gdk-ee/gitlab/lib/tasks/gitlab/setup.rake:36:in `setup_db'
/Users/tyler/apps/gdk-ee/gitlab/lib/tasks/gitlab/setup.rake:5:in `block (2 levels) in <main>'
/Users/tyler/apps/gdk-ee/gitlab/lib/tasks/dev.rake:7:in `block (2 levels) in <main>'
/Users/tyler/.rbenv/versions/2.6.3/bin/bundle:23:in `load'
/Users/tyler/.rbenv/versions/2.6.3/bin/bundle:23:in `<main>'
Tasks: TOP => db:seed_fu
(See full trace by running task with --trace)
support/bootstrap-rails failed
make: *** [postgresql/data] Error 1

It turns out to be a namespacing problem from a recent commit (https://gitlab.com/gitlab-org/gitlab-ee/commit/d196ad3f299090977d5fcc39d3584884b028d671) where we were simply missing a leading :: on the Packages module name.

I don't think there are any risks involved with the change, but I'm not very familiar with the app yet to know. Are there

Does this MR meet the acceptance criteria?

Yes? Again, this is my first MR so I'm not sure.

Conformity

Performance and testing

No new performance implications.

Security

No changes related to security.

Edited by Tyler Amos

Merge request reports