Skip to content

Make math_rendering_limits_enabled a cascading attribute

Brett Walker requested to merge bw-cascade-math-rendering-limits into master

What does this MR do and why?

Related to #424271 (closed)

Make the current instance setting math_rendering_limits_enabled into a cascading attribute that will be settable/lockable at an instance level and a group level.

Both the GraphQL and REST API can now query and update a group with these attributes

Currently, the instance value is used to turn on/off the limits in math rendering. This expands that ability to groups. This MR is only the first piece. !143550 (merged) will change the code to use the new cascaded value.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

To test the GraphQL

Use the following in the graphQL explorer, http://localhost:3000/-/graphql-explorer

query group {
  group(fullPath: "flightjs") {
    id
    mathRenderingLimitsEnabled
    lockMathRenderingLimitsEnabled
  }
}

mutation update {
  groupUpdate(input: {fullPath: "flightjs", mathRenderingLimitsEnabled: false}) {
    group {
      id
    }
  }
}

First run the query, and mathRenderingLimitsEnabled should be true (the default), and lockMathRenderingLimitsEnabled should be false.

Now play with mutation to see that it works correctly.

Edited by Brett Walker

Merge request reports