Skip to content

Artifacts table: use skeleton loader for loading state

Miranda Fluharty requested to merge 419795-artifacts-table-loading-state into master

What does this MR do and why?

#⃣ For Frontend: Artifacts: Improve table loading state (#419795 - closed)

Remove the loading spinner, use a skeleton loader when loading

Why? If we want to reload the list when job artifacts are deleted, then this should be less jarring than switching to a loading spinner (what we currently do when loading).

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
Screen_Recording_2024-02-21_at_15.59.53 Screen_Recording_2024-02-21_at_15.57.01

How to set up and validate locally

  1. git checkout 419795-artifacts-table-loading-state
  2. find/make/clone a project that generates artifacts
  3. run a few pipelines to generate some artifacts to work with
  4. navigate to the project, and in the sidebar choose Build => Artifacts
  5. verify that the table shows a skeleton loader while artifacts are initially loading
  6. optionally, run enough jobs to make the list paginate (run > 20 jobs, or change JOBS_PER_PAGE to a number smaller than the number of jobs you ran) and verify that the same skeleton loader is used when the next page is loading
Edited by Miranda Fluharty

Merge request reports