Skip to content

Add cleanup to testAuthServer

Gavin Hinfey requested to merge 433440-replace-cleanup-testAuthServer into master

What does this MR do and why?

Replace cleanup with t.Cleanup in workhorse tests.

In many places we return a cleanup function and defer its execution in order to cleanup after tests. This MR refactors it to use T.Cleanup as it has been added to Go.

Checks

  • (testAuthServer) -- main_test.go -- this function can close the started server in t.Cleanup: it will save us from calling defer ts.Close() everytime

of #433440 (closed)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

Passing workhorse tests should be sufficient.

Related to #433440 (closed)

Merge request reports