Skip to content

Start using structured errors of user revert

Yadong Wang requested to merge gitlab-community/gitlab:start-using-structured-errors-of-UserRevert into master

What does this MR do and why?

UserRevert can return structured errors with the introduction of operations: Return structured errors in UserRevert (gitaly!6533 - merged). We should update Rails to use these structured errors when set, and then roll out the feature flag to return the structured errors from Gitaly.

We need the following steps to introduce structured errors for UserRevert.

  • First merge the protobufs only in Gitaly.（Merged via gitaly!6667 (merged) ）
  • Update Rails to handle the new errors properly. (This MR)
  • Merge the behavior changes(return structured errors) behind the feature flag in Gitaly.

After that, the Gitaly team can handle the feature flag rollout.

For Close: gitaly#5753 (closed)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

NA

How to set up and validate locally

The new proto definition MR gitaly!6667 (merged) is merged , and we have proto gem published (16.10.0-rc1), so just run GDK test on local.

Edited by Yadong Wang

Merge request reports