Skip to content

Draft: Add non-blocking way to pop JobWaiter list

Luke Duncalfe requested to merge ld-JobWaiter-non-blocking into master

What does this MR do and why?

JobWaiter#wait uses BLPOP which is a blocking call to Redis and pops a single element from the list.

This is an experiment with using LPOP which can pop off many elements at the same time to achieve the same thing.

For the Import and Integrate team's use of JobWaiter this method might be more performant.

https://gitlab.com/gitlab-org/manage/import-and-integrate/discussions/-/issues/61#note_1748410729

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Merge request reports