Skip to content
Snippets Groups Projects

Fix spec failure for table in gitab_main

Merged Manoj M J requested to merge mmj-fix-test into master
All threads resolved!

What does this MR do and why?

This spec failed in https://gitlab.com/gitlab-org/gitlab/-/jobs/6016420149, and the reason was traced to the fact that the gitlab_schema of vulnerabilities table was changing from gitlab_main to gitlab_main_cell here.

Because of this reason, we are fixing this spec to remove references to gitlab_main. This is because efforts are underway to classify tables as either gitlab_main_cell or gitlab_main_clusterwide, and eventually the gitlab_main schema will cease to exist.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Manoj M J

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Dylan Griffith removed review request for @DylanGriffith

    removed review request for @DylanGriffith

  • Manoj M J added 1 commit

    added 1 commit

    • 54b49810 - Use sequence of first available table

    Compare with previous version

  • Manoj M J revoked approvals from @tigerwnz by pushing to the branch

    revoked approvals from @tigerwnz by pushing to the branch

  • Manoj M J requested review from @DylanGriffith

    requested review from @DylanGriffith

  • Dylan Griffith
  • Dylan Griffith approved this merge request

    approved this merge request

  • @manojmj I've only got non-blocking feedback so I'll go ahead and merge here.

  • Dylan Griffith enabled an automatic merge when all merge checks for 54b49810 pass

    enabled an automatic merge when all merge checks for 54b49810 pass

  • Dylan Griffith resolved all threads

    resolved all threads

  • merged

  • Dylan Griffith mentioned in commit 45120b7a

    mentioned in commit 45120b7a

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading