Skip to content

Use group ID instead of root group ID for query

Eduardo Sanz García requested to merge eduardosanz/use-group-id into master

What does this MR do and why?

Use group ID instead of root group ID for query

In the backend counterpart MR, it has been decided to use the group ID instead of the top-level group ID for getting the SAML users: !141040 (comment 1743246071)

This API query is not yet been used because it is under a feature flag, group_users_saml, that is currently off in all environments. So it is safe to deploy.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

No changes.

Screen_Recording_2023-11-28_at_17.12.35

How to set up and validate locally

  1. Enable the feature flag: echo "Feature.enable(:group_user_saml)" | gdk rails console
  2. Apply backend MR: curl https://gitlab.com/gitlab-org/gitlab/-/merge_requests/138075.diff | git apply
  3. Enabled SAML for a top-level group
  4. Enabled Enforce SSO-only authentication for web activity for this group. Screenshot_2023-11-28_at_15.26.02
  5. Go to a group or project member page that belong to the top-level group in step #1
  6. Select Invite members button or Invite team members from the navigation superbar. Screen_Recording_2023-11-28_at_17.12.35

!141040 (comment 1743246071)

Edited by Eduardo Sanz García

Merge request reports