Skip to content

Fulfillment CI: Increase notes API per_page, Remove dynamic bot user id

Ryan Cobb requested to merge rc/ci_fulfillment_quarantine_increase_notes_api into master

What does this MR do and why?

In our qa-quarantine-report job, we check existing comments to make sure we don't make a bot comment if one already exists. The notes API we use returns 20 items and can be paginated. If there are more than 20 notes, this can cause the bot to post multiple comments.

This MR:

  1. Increase the number of items returned from the notes API from 20 to 100.
  2. It does not fix cases where there are paginated results. This may be addressed in customers-gitlab-com#8503
  3. Use hardcoded bot user id instead dynamically fetching it as ID should not be changing.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Ryan Cobb

Merge request reports