Auto approve pending members when disabling user cap
What does this MR do and why?
This change means that when a group admin updates the user cap setting to disable it (i.e. turning it off once it's been enabled), we will now auto-approve any pending members.
Members added to a group that is over it's user cap get put into a pending state, which means they don't have access, and importantly, don't become billable, until they have been approved.
Group admins are now warned that disabling the setting will auto-approve any pending members.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
| Before | After |
|---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Enable the user cap setting in group settings (Group -> Settings -> General -> User Cap), setting it to a low number e.g.
1 - Invite a new user to your group with a billable role, e.g. maintainer. They will be added in a pending state and visible under Group -> Settings -> Usage Quotas -> Pending Members
- Update the Group's settings to disable the user cap (i.e. leaving it empty) - you should see a modal
- The pending member should now be approved and displayed under the seats tab of the Usage Quotas page