General improvements in the terms pages

What does this MR do and why?

General improvements in the terms pages

• Remove layouts/broadcast (notifications messages could cover the accept button)
• Simplified HTML markup
• Remove unneeded classes
• Repair dark mode

Changelog: changed

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Light mode

Before	After

Dark mode

Before	After

How to set up and validate locally

1. As an admin, enforce the acceptance of the terms: /admin/application_settings/general#js-terms-settings
2. On an incognito window, go to /-/users/terms

assigned to @eduardosanz

changed the description

added backend frontend labels

	2 Warnings
	This merge request contains lines with testid selectors. Please ensure e2e:package-and-test job is run.
	You've made some app changes, but didn't add any tests. That's OK as long as you're refactoring existing code, but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.

testid selectors

The following changed lines in this MR contain testid selectors:

app/assets/javascripts/terms/components/app.vue

-    <div class="gl-relative gl-pb-0 gl-px-0" data-testid="terms-content">
+    <div class="gl-relative" data-testid="terms-content">

app/views/layouts/terms.html.haml

-                    = render Pajamas::AvatarComponent.new(current_user, size: 32, avatar_options: { data: { testid: 'user-avatar-content' } })
+                = render Pajamas::AvatarComponent.new(current_user, size: 32, avatar_options: { data: { testid: 'user-avatar-content' } })

If the e2e:package-and-test job in the qa stage has run automatically, please ensure the tests are passing. If the job has not run, please start the manual:e2e-test-pipeline-generate job in the prepare stage and ensure the tests in follow-up:e2e:package-and-test-ee pipeline are passing.

For the list of known failures please refer to the latest pipeline triage issue.

If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.

Reviewer roulette

Category	Reviewer	Maintainer
backend	@ngala (UTC+5.5, 3.5 hours ahead of author)	@cablett (UTC+12, 10 hours ahead of author)
frontend	@vvempati (UTC+12, 10 hours ahead of author)	@himkp (UTC+2, same timezone as author)
UX	@ipelaez1 (UTC-4, 6 hours behind author)	Maintainer review is optional for UX

Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

Proper labels assigned to this merge request. Please ignore me.

@eduardosanz - please see the following guidance and update this merge request.

	1 Error
	Please add typebug typefeature, or typemaintenance label to this merge request.

Bundle size analysis [beta]

This compares changes in bundle size for entry points between the commits 2cb4c4e4 and c4b68801

Special assets

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
average	4.3 MB	4.3 MB	-	0.0 %
mainChunk	3.3 MB	3.3 MB	-	0.0 %

---

Note: We do not have exact data for 2cb4c4e4. So we have used data from: ab3d03a5.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.

Please look at the full report for more details

---

Read more about how this report works.

Generated by Danger

E2E Test Result Summary

allure-report-publisher generated test report!

e2e-test-on-gdk: test report for 95e334a6

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Package     | 16     | 0      | 15      | 0     | 31    | ✅     |
| Create      | 127    | 0      | 12      | 0     | 139   | ✅     |
| Verify      | 43     | 0      | 2       | 0     | 45    | ✅     |
| Plan        | 68     | 0      | 2       | 0     | 70    | ✅     |
| Data Stores | 30     | 0      | 1       | 0     | 31    | ✅     |
| Govern      | 71     | 0      | 0       | 0     | 71    | ✅     |
| Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
| Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
| Secure      | 2      | 0      | 0       | 0     | 2     | ✅     |
| Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
| Fulfillment | 1      | 0      | 0       | 0     | 1     | ✅     |
| Manage      | 0      | 0      | 1       | 0     | 1     | ➖     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 373    | 0      | 33      | 0     | 406   | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+

e2e-package-and-test: test report for 95e334a6

expand test summary

+-------------------------------------------------------------+
|                       suites summary                        |
+--------+--------+--------+---------+-------+-------+--------+
|        | passed | failed | skipped | flaky | total | result |
+--------+--------+--------+---------+-------+-------+--------+
| Govern | 104    | 1      | 8       | 3     | 113   | ❌     |
| Create | 270    | 0      | 34      | 0     | 304   | ✅     |
+--------+--------+--------+---------+-------+-------+--------+
| Total  | 374    | 1      | 42      | 3     | 417   | ❌     |
+--------+--------+--------+---------+-------+-------+--------+

added groupauthentication label

added devopsgovern sectionsec labels

added 1466 commits

• 35e141c9...cd7eff51 - 1465 commits from branch master
• 5b9e7d21 - General improvements in the terms pages

Compare with previous version

changed milestone to %16.10

mentioned in issue gitlab-org/quality/triage-reports#16650 (closed)

changed milestone to %16.11

added missed:16.10 label

mentioned in issue gitlab-org/quality/triage-reports#16840 (closed)

@eduardosanz This popped up in our idle MRs, do we still want to merge these changes? (the rest of the T&C work was already done)

removed milestone %16.11

marked this merge request as draft

added 17260 commits

• 5b9e7d21...6e90b257 - 17259 commits from branch master
• c4b68801 - General improvements in the terms pages

Compare with previous version

added 11189 commits

• c4b68801...69be7af5 - 11188 commits from branch master
• 8e7d2770 - General improvements in the terms pages

Compare with previous version