Skip to content

Drop `vulnerabilities` Column From `SbomOccurences`

What does this MR do and why?

vulnerabilities is an ignored column (source)

This MR drops the column for step 2 of the 3-MR drop column process

Check for indexes or constraints

Using the command \d+ sbom_occurrences on postgres.ai indicates there are NOT indexes and constraints

index fk constraint
image image

migration output

bundle exec rails db:migrate output
~/gitlab-development-kit/gitlab$ bundle exec rails db:migrate 
main: == [advisory_lock_connection] object_id: 117620, pg_backend_pid: 576484
main: == 20240124084726 RemoveVulnerabilitiesColumnFromSbomOccurences: migrating ====
main: -- remove_column(:sbom_occurrences, :vulnerabilities)
main:    -> 0.0013s
main: == 20240124084726 RemoveVulnerabilitiesColumnFromSbomOccurences: migrated (0.0042s) 

main: == [advisory_lock_connection] object_id: 117620, pg_backend_pid: 576484
ci: == [advisory_lock_connection] object_id: 117980, pg_backend_pid: 576486
ci: == 20240124084726 RemoveVulnerabilitiesColumnFromSbomOccurences: migrating ====
ci: -- remove_column(:sbom_occurrences, :vulnerabilities)
ci:    -> 0.0009s
ci: == 20240124084726 RemoveVulnerabilitiesColumnFromSbomOccurences: migrated (0.0078s) 

ci: == [advisory_lock_connection] object_id: 117980, pg_backend_pid: 576486
bundle exec rails db:migrate:down:main VERSION=20240124084726 output
~/gitlab-development-kit/gitlab$ bundle exec rails db:migrate:down:main VERSION=20240124084726
main: == [advisory_lock_connection] object_id: 117160, pg_backend_pid: 577294
main: == 20240124084726 RemoveVulnerabilitiesColumnFromSbomOccurences: reverting ====
main: -- add_column(:sbom_occurrences, :vulnerabilities, :jsonb, {:default=>[]})
main:    -> 0.0018s
main: == 20240124084726 RemoveVulnerabilitiesColumnFromSbomOccurences: reverted (0.0047s) 

main: == [advisory_lock_connection] object_id: 117160, pg_backend_pid: 577294
bundle exec rails db:migrate:down:ci VERSION=20240124084726 output
~/gitlab-development-kit/gitlab$ bundle exec rails db:migrate:down:ci VERSION=20240124084726
ci: == [advisory_lock_connection] object_id: 117160, pg_backend_pid: 577725
ci: == 20240124084726 RemoveVulnerabilitiesColumnFromSbomOccurences: reverting ====
ci: -- add_column(:sbom_occurrences, :vulnerabilities, :jsonb, {:default=>[]})
ci:    -> 0.0015s
ci: == 20240124084726 RemoveVulnerabilitiesColumnFromSbomOccurences: reverted (0.0091s) 

ci: == [advisory_lock_connection] object_id: 117160, pg_backend_pid: 577725

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #430959 (closed)

Edited by Michael Becker

Merge request reports