Skip to content

Refactor preloader to use namespace

Terri Chu requested to merge tchu-refactor-to-use-namespace-in-preloader into master

What does this MR do and why?

Discovered while working on !142238 (comment 1738327790)

I do not think we want to limit the preloading to group type namespaces only.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Database

There is only one change to the query before and after and it's wether the join applies the type = 'Group' to the query

before - using :group 

SELECT
    namespaces.*,
    root_query.project_id AS source_id
FROM
    "namespaces"
    INNER JOIN (
        SELECT
            "projects"."id",
            "projects"."namespace_id",
            projects.id AS project_id,
            namespaces.traversal_ids[1] AS root_id
        FROM
            "projects"
            INNER JOIN "namespaces" ON "namespaces"."type" = 'Group'
                AND "namespaces"."id" = "projects"."namespace_id"
                AND "namespaces"."type" = 'Group'
        WHERE
            "projects"."id" IN (
                SELECT
                    "projects"."id"
                FROM
                    "projects"
                LIMIT 10)) AS root_query ON root_query.root_id = namespaces.id
/*application:console,db_config_name:main,console_hostname:terrichus-MBP.localdomain,console_username:terrichu,line:/app/models/preloaders/project_root_ancestor_preloader.rb:19:in `group_by'*/

after - using :namespace 

SELECT
    namespaces.*,
    root_query.project_id AS source_id
FROM
    "namespaces"
    INNER JOIN (
        SELECT
            "projects"."id",
            "projects"."namespace_id",
            projects.id AS project_id,
            namespaces.traversal_ids[1] AS root_id
        FROM
            "projects"
            INNER JOIN "namespaces" ON "namespaces"."id" = "projects"."namespace_id"
        WHERE
            "projects"."id" IN (
                SELECT
                    "projects"."id"
                FROM
                    "projects"
                LIMIT 10)) AS root_query ON root_query.root_id = namespaces.id

/*application:console,db_config_name:main,console_hostname:terrichus-MBP.localdomain,console_username:terrichu,line:/app/models/preloaders/project_root_ancestor_preloader.rb:19:in `group_by'*/

How to set up and validate locally

N/A

Edited by Terri Chu

Merge request reports