Skip to content

Improvements for `::Keeps::OverdueFinalizeBackgroundMigration`

Dylan Griffith requested to merge improvements-hosuekeeper-finalize-migrations into master

What does this MR do and why?

  1. Fix housekeeper batched background migration file names chomp
  2. Change keep finalize migration cuttoff to 16.7. This is the last required stop.
  3. Ignore missing last enqueue migration. Skip if we can't find the last migration corresponding to a migration that needs to be finalized.
  4. Change only occurence of using MIGRATION_NAME = This is not picked up by keeps/overdue_finalize_background_migration.rb because it is grepping for MIGRATION =. That is the standard way that it's generated and documented and this was the only occurence so I figured I'd just fix this rather than making the keep more flexible.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Merge request reports