Introduce a warning message for pipeline trigger token form
original issue: #416619 (closed)
What does this MR do and why?
Trigger Tokens are quite frequently leaked as people assume that the only thing they can do is trigger a pipeline which is, in most cases, a harmless operation.
As an immediate step would be solved with additional messages so that maintainers could pay more attention to it.
Changelog: changed
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Merge request reports
Activity
assigned to @dbiryukov
added sectionci label and removed sectionops label
- A deleted user
added backend label
2 Warnings ba4ef063: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. db88a5c2: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend @mokhax
(UTC-7, 8 hours behind author)
@ck3g
(UTC+1, same timezone as author)
frontend @dstull
(UTC-5, 6 hours behind author)
@eduardosanz
(UTC+1, same timezone as author)
~"Verify" Reviewer review is optional for ~"Verify" @allison.browne
(UTC-5, 6 hours behind author)
Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerchanged milestone to %16.9
mentioned in issue #416619 (closed)
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 9a5deaa2expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Verify | 31 | 0 | 0 | 0 | 31 | ✅ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | | Create | 8 | 0 | 3 | 0 | 11 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Govern | 3 | 0 | 0 | 0 | 3 | ✅ | | Plan | 4 | 0 | 0 | 0 | 4 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 52 | 0 | 4 | 0 | 56 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 9a5deaa2expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Verify | 138 | 0 | 27 | 0 | 165 | ✅ | | Create | 149 | 0 | 19 | 2 | 168 | ✅ | | Package | 0 | 0 | 2 | 0 | 2 | ➖ | | Data Stores | 4 | 0 | 0 | 0 | 4 | ✅ | | Plan | 8 | 0 | 0 | 0 | 8 | ✅ | | Govern | 6 | 0 | 0 | 0 | 6 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 313 | 0 | 48 | 2 | 361 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
removed backend label
added documentation label
- Resolved by Mireya Andres
@mgandres Could you please review a frontend here?
@marcel.amirault Could you please review the message writings?
requested review from @mgandres and @marcel.amirault
- Resolved by Dmytro Biryukov
added feature flagskipped label
- Resolved by Mireya Andres
added Technical Writing UI text labels
removed documentation label
removed review request for @marcel.amirault
- A deleted user
added backend label
added 3 commits
- Resolved by drew stachon
@mgandres I added a namespace, also I have included a link into the message.
Please take a look
requested review from @mgandres
- Resolved by Mireya Andres
@mgandres
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
added pipeline:mr-approved label
requested review from @drew
removed review request for @mgandres
mentioned in commit 84314511
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2763 (merged)