Skip to content
Snippets Groups Projects

Introduce a warning message for pipeline trigger token form

Merged Dmytro Biryukov requested to merge dbiryukov_restrict_trigger_variables_mr-416619 into master
All threads resolved!

original issue: #416619 (closed)

What does this MR do and why?

Trigger Tokens are quite frequently leaked as people assume that the only thing they can do is trigger a pipeline which is, in most cases, a harmless operation.

As an immediate step would be solved with additional messages so that maintainers could pay more attention to it.

Changelog: changed

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
image image

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Dmytro Biryukov

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Marcel Amirault removed review request for @marcel.amirault

    removed review request for @marcel.amirault

  • Dmytro Biryukov added 1 commit

    added 1 commit

    • d6459833 - Great, thanks for the suggested change!

    Compare with previous version

  • A deleted user added backend label

    added backend label

  • Dmytro Biryukov added 3 commits

    added 3 commits

    Compare with previous version

  • Dmytro Biryukov requested review from @mgandres

    requested review from @mgandres

  • Mireya Andres approved this merge request

    approved this merge request

  • Mireya Andres resolved all threads

    resolved all threads

  • Mireya Andres requested review from @drew

    requested review from @drew

  • Mireya Andres removed review request for @mgandres

    removed review request for @mgandres

  • drew stachon resolved all threads

    resolved all threads

  • drew stachon approved this merge request

    approved this merge request

  • merged

  • drew stachon mentioned in commit 84314511

    mentioned in commit 84314511

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading