Skip to content

Update scan result policy name

Alexander Turinske requested to merge 413782-update-scan-result-policy-name into master

What does this MR do and why?

Update scan result policy name

  • update it to Merge request approval policy in title and policy list
  • update it to approval_policy for the type
  • only change user-facing instances; leave references to scan result policy in code for follow-up MR
  • change policy list filter
  • update tests

Changelog: changed

EE: true

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Page Before After
Policy list image policy_list_-_a
Policy list - filter old url works old_url_works new url works new_url_works
Select new policy image new_selector_-_a
New policy page image new_policy_-_a
Edit policy list image Still navigates to scan_result until backend MR is merged edit_page

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Upload an GitLab Ultimate license
  2. Navigate to a project/group => Secure => Policies => New policy
  3. Verify policy type selection
  4. Select "Merge request approval policy"
  5. Verify new policy page
  6. Create the new policy
  7. Navigate to a project/group => Secure => Policies
  8. Verify policy list and drawer
  9. Select Edit policy
  10. Verify Edit policy page
  11. Go to a project => Settings => Merge request
  12. Verify settings
  13. Create an MR that violates a policy
  14. Verify MR widget

Related to #413782 (closed)

Edited by Alexander Turinske

Merge request reports