Update scan result policy name
What does this MR do and why?
Update scan result policy name
- update it to
Merge request approval policy
in title and policy list - update it to
approval_policy
for thetype
- only change user-facing instances; leave references to
scan result policy
in code for follow-up MR - change policy list filter
- update tests
Changelog: changed
EE: true
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Page | Before | After |
---|---|---|
Policy list | ![]() |
![]() |
Policy list - filter | old url works ![]() ![]() |
|
Select new policy | ![]() |
![]() |
New policy page | ![]() |
![]() |
Edit policy list | ![]() |
Still navigates to scan_result until backend MR is merged ![]() |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Upload an GitLab Ultimate license
- Navigate to a project/group => Secure => Policies => New policy
- Verify policy type selection
- Select "Merge request approval policy"
- Verify new policy page
- Create the new policy
- Navigate to a project/group => Secure => Policies
- Verify policy list and drawer
- Select
Edit policy
- Verify Edit policy page
- Go to a project => Settings => Merge request
- Verify settings
- Create an MR that violates a policy
- Verify MR widget
Related to #413782 (closed)
Edited by Alexander Turinske