Drop ignored columns from geo_node_statuses table

What does this MR do and why?

We have removed the legacy replication/verification code, and these columns have been ignored for a long time. So, it is time for a clean up.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Migrations ouput

• Up

% bundle exec rails db:migrate
main: == [advisory_lock_connection] object_id: 183420, pg_backend_pid: 99755
main: == 20240118190758 RemoveIgnoredColumnsFromGeoNodeStatuses: migrating ==========
main: -- remove_column(:geo_node_statuses, :container_repositories_count, {:if_exists=>true})
main:    -> 0.0132s
main: -- remove_column(:geo_node_statuses, :container_repositories_failed_count, {:if_exists=>true})
main:    -> 0.0018s
main: -- remove_column(:geo_node_statuses, :container_repositories_registry_count, {:if_exists=>true})
main:    -> 0.0015s
main: -- remove_column(:geo_node_statuses, :container_repositories_synced_count, {:if_exists=>true})
main:    -> 0.0013s
main: -- remove_column(:geo_node_statuses, :job_artifacts_count, {:if_exists=>true})
main:    -> 0.0017s
main: -- remove_column(:geo_node_statuses, :job_artifacts_failed_count, {:if_exists=>true})
main:    -> 0.0012s
main: -- remove_column(:geo_node_statuses, :job_artifacts_synced_count, {:if_exists=>true})
main:    -> 0.0011s
main: -- remove_column(:geo_node_statuses, :job_artifacts_synced_missing_on_primary_count, {:if_exists=>true})
main:    -> 0.0011s
main: -- remove_column(:geo_node_statuses, :lfs_objects_count, {:if_exists=>true})
main:    -> 0.0013s
main: -- remove_column(:geo_node_statuses, :lfs_objects_failed_count, {:if_exists=>true})
main:    -> 0.0011s
main: -- remove_column(:geo_node_statuses, :lfs_objects_synced_count, {:if_exists=>true})
main:    -> 0.0011s
main: -- remove_column(:geo_node_statuses, :lfs_objects_synced_missing_on_primary_count, {:if_exists=>true})
main:    -> 0.0010s
main: == 20240118190758 RemoveIgnoredColumnsFromGeoNodeStatuses: migrated (0.0304s) =

main: == [advisory_lock_connection] object_id: 183420, pg_backend_pid: 99755
ci: == [advisory_lock_connection] object_id: 183620, pg_backend_pid: 99757
ci: == 20240118190758 RemoveIgnoredColumnsFromGeoNodeStatuses: migrating ==========
ci: -- remove_column(:geo_node_statuses, :container_repositories_count, {:if_exists=>true})
ci:    -> 0.0033s
ci: -- remove_column(:geo_node_statuses, :container_repositories_failed_count, {:if_exists=>true})
ci:    -> 0.0013s
ci: -- remove_column(:geo_node_statuses, :container_repositories_registry_count, {:if_exists=>true})
ci:    -> 0.0012s
ci: -- remove_column(:geo_node_statuses, :container_repositories_synced_count, {:if_exists=>true})
ci:    -> 0.0013s
ci: -- remove_column(:geo_node_statuses, :job_artifacts_count, {:if_exists=>true})
ci:    -> 0.0015s
ci: -- remove_column(:geo_node_statuses, :job_artifacts_failed_count, {:if_exists=>true})
ci:    -> 0.0012s
ci: -- remove_column(:geo_node_statuses, :job_artifacts_synced_count, {:if_exists=>true})
ci:    -> 0.0011s
ci: -- remove_column(:geo_node_statuses, :job_artifacts_synced_missing_on_primary_count, {:if_exists=>true})
ci:    -> 0.0015s
ci: -- remove_column(:geo_node_statuses, :lfs_objects_count, {:if_exists=>true})
ci:    -> 0.0011s
ci: -- remove_column(:geo_node_statuses, :lfs_objects_failed_count, {:if_exists=>true})
ci:    -> 0.0010s
ci: -- remove_column(:geo_node_statuses, :lfs_objects_synced_count, {:if_exists=>true})
ci:    -> 0.0012s
ci: -- remove_column(:geo_node_statuses, :lfs_objects_synced_missing_on_primary_count, {:if_exists=>true})
ci:    -> 0.0011s
ci: == 20240118190758 RemoveIgnoredColumnsFromGeoNodeStatuses: migrated (0.0245s) =

ci: == [advisory_lock_connection] object_id: 183620, pg_backend_pid: 99757

• Down

bundle exec rails db:rollback:main
main: == [advisory_lock_connection] object_id: 183020, pg_backend_pid: 297
main: == 20240118190758 RemoveIgnoredColumnsFromGeoNodeStatuses: reverting ==========
main: -- add_column(:geo_node_statuses, :container_repositories_count, :integer, {:if_not_exists=>true})
main:    -> 0.0118s
main: -- add_column(:geo_node_statuses, :container_repositories_failed_count, :integer, {:if_not_exists=>true})
main:    -> 0.0015s
main: -- add_column(:geo_node_statuses, :container_repositories_registry_count, :integer, {:if_not_exists=>true})
main:    -> 0.0015s
main: -- add_column(:geo_node_statuses, :container_repositories_synced_count, :integer, {:if_not_exists=>true})
main:    -> 0.0014s
main: -- add_column(:geo_node_statuses, :job_artifacts_count, :integer, {:if_not_exists=>true})
main:    -> 0.0013s
main: -- add_column(:geo_node_statuses, :job_artifacts_failed_count, :integer, {:if_not_exists=>true})
main:    -> 0.0015s
main: -- add_column(:geo_node_statuses, :job_artifacts_synced_count, :integer, {:if_not_exists=>true})
main:    -> 0.0018s
main: -- add_column(:geo_node_statuses, :job_artifacts_synced_missing_on_primary_count, :integer, {:if_not_exists=>true})
main:    -> 0.0016s
main: -- add_column(:geo_node_statuses, :lfs_objects_count, :integer, {:if_not_exists=>true})
main:    -> 0.0012s
main: -- add_column(:geo_node_statuses, :lfs_objects_failed_count, :integer, {:if_not_exists=>true})
main:    -> 0.0015s
main: -- add_column(:geo_node_statuses, :lfs_objects_synced_count, :integer, {:if_not_exists=>true})
main:    -> 0.0014s
main: -- add_column(:geo_node_statuses, :lfs_objects_synced_missing_on_primary_count, :integer, {:if_not_exists=>true})
main:    -> 0.0020s
main: == 20240118190758 RemoveIgnoredColumnsFromGeoNodeStatuses: reverted (0.0314s) =

main: == [advisory_lock_connection] object_id: 183020, pg_backend_pid: 297

% bundle exec rails db:rollback:ci
ci: == [advisory_lock_connection] object_id: 182960, pg_backend_pid: 890
ci: == 20240118190758 RemoveIgnoredColumnsFromGeoNodeStatuses: reverting ==========
ci: -- add_column(:geo_node_statuses, :container_repositories_count, :integer, {:if_not_exists=>true})
ci:    -> 0.0128s
ci: -- add_column(:geo_node_statuses, :container_repositories_failed_count, :integer, {:if_not_exists=>true})
ci:    -> 0.0015s
ci: -- add_column(:geo_node_statuses, :container_repositories_registry_count, :integer, {:if_not_exists=>true})
ci:    -> 0.0016s
ci: -- add_column(:geo_node_statuses, :container_repositories_synced_count, :integer, {:if_not_exists=>true})
ci:    -> 0.0017s
ci: -- add_column(:geo_node_statuses, :job_artifacts_count, :integer, {:if_not_exists=>true})
ci:    -> 0.0016s
ci: -- add_column(:geo_node_statuses, :job_artifacts_failed_count, :integer, {:if_not_exists=>true})
ci:    -> 0.0016s
ci: -- add_column(:geo_node_statuses, :job_artifacts_synced_count, :integer, {:if_not_exists=>true})
ci:    -> 0.0015s
ci: -- add_column(:geo_node_statuses, :job_artifacts_synced_missing_on_primary_count, :integer, {:if_not_exists=>true})
ci:    -> 0.0018s
ci: -- add_column(:geo_node_statuses, :lfs_objects_count, :integer, {:if_not_exists=>true})
ci:    -> 0.0014s
ci: -- add_column(:geo_node_statuses, :lfs_objects_failed_count, :integer, {:if_not_exists=>true})
ci:    -> 0.0012s
ci: -- add_column(:geo_node_statuses, :lfs_objects_synced_count, :integer, {:if_not_exists=>true})
ci:    -> 0.0012s
ci: -- add_column(:geo_node_statuses, :lfs_objects_synced_missing_on_primary_count, :integer, {:if_not_exists=>true})
ci:    -> 0.0014s
ci: == 20240118190758 RemoveIgnoredColumnsFromGeoNodeStatuses: reverted (0.0376s) =

ci: == [advisory_lock_connection] object_id: 182960, pg_backend_pid: 890

Related issue

Related to #426645 (closed)